Skip to content

Fix footer animation cutoff #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
5ran6 merged 4 commits into from
Jan 14, 2026
Merged

Fix footer animation cutoff #347

5ran6 merged 4 commits into from
Jan 14, 2026

Conversation

@Dprof-in-tech
Copy link
Collaborator

@Dprof-in-tech Dprof-in-tech commented Jan 13, 2026 •
edited by coderabbitai bot
Loading

Description

This pull request makes a minor adjustment to the layout of the Footer component. The minimum height of the footer has been increased for both default and large screen sizes to improve visual spacing.

  • Increased the default minimum height from 360px to 440px, and the large screen minimum height from 540px to 640px in the Footer component (app/components/Footer.tsx).

References

fixes the footer animation cutoff directly in prod.

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation and tests for new/changed functionality in this PR
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not main

By submitting a PR, I agree to Paycrest's Contributor Code of Conduct and Contribution Guide.

Summary by CodeRabbit

  • Style
    • Increased footer height on all screen sizes for improved visual spacing and layout balance.

✏️ Tip: You can customize this high-level summary in your review settings.

@Dprof-in-tech Dprof-in-tech requested a review from chibie as a code owner January 13, 2026 20:00
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 13, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

The Footer component's responsive minimum height classes are increased across breakpoints: from 360px to 440px on mobile, and from 540px to 640px on larger screens. This purely layout-based adjustment expands the footer's vertical space without introducing new functionality.

Changes

Cohort / File(s) Summary
Footer Styling
app/components/Footer.tsx		 Updated responsive minimum height classes: min-h-[360px] → min-h-[440px] and lg:min-h-[540px] → lg:min-h-[640px]

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • PR #341 — Applies the identical Footer.tsx height class updates (360→440, 540→640).
  • PR #327 — Also modifies the Footer component with a different footer illustration change.
  • PR #337 — Updates Footer component animation and illustration styling.

Suggested reviewers

  • chibie
  • 5ran6

Poem

🐰 A footer grows taller, oh what a sight,
From 360 to 440, reaching new height!
The rabbit hops round, reviewing with care,
Layout adjustments floating in air! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix footer animation cutoff' clearly and concisely describes the main purpose of the PR, which is fixing a footer animation cutoff issue through layout adjustments.
Description check ✅ Passed The PR description covers the purpose, implementation details, and references an issue. However, testing and documentation checklist items remain unchecked despite being required template sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4a7a477 and 34f208d.

📒 Files selected for processing (1)
  • app/components/Footer.tsx
🔇 Additional comments (1)
app/components/Footer.tsx (1)

121-121: LGTM!

The increased min-height values (440px mobile, 640px large screens) appropriately accommodate the rocket animation, which moves up to 120px vertically and scales up to 1.22x during the pending state. This should resolve the animation cutoff issue.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Dprof-in-tech Dprof-in-tech changed the base branch from main to stable January 13, 2026 20:01
@Dprof-in-tech Dprof-in-tech requested a review from 5ran6 January 13, 2026 20:06
5ran6
5ran6 approved these changes Jan 14, 2026
View reviewed changes
Copy link
Contributor

@5ran6 5ran6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@5ran6 5ran6 merged commit 39d3365 into stable Jan 14, 2026
1 check passed
@5ran6 5ran6 deleted the fix-footer-animation-cutoff branch January 14, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@5ran6 5ran6 5ran6 approved these changes

@chibie chibie Awaiting requested review from chibie chibie is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dprof-in-tech @5ran6